Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF Viewer Refreshes when interacting with webui #2145

Open
whizzzkid opened this issue Aug 2, 2023 · 1 comment
Open

PDF Viewer Refreshes when interacting with webui #2145

whizzzkid opened this issue Aug 2, 2023 · 1 comment
Labels
area/screen/files Issues related to Files screen kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design topic/perf Performance

Comments

@whizzzkid
Copy link
Contributor

Describe the bug
While interacting with other elements on page, the PDF viewer re-renders.

To Reproduce
Steps to reproduce the behavior:

  1. Import a sample PDF in either webui/desktop
  2. Try interacting with ui elements around the pdf
  3. PDF viewer re-renders.
  4. ReRenders can be expensive and based on the size of file it can take longer.

Expected behavior
It should not re-render.

Screenshots

pdf-view-re-renders.mov

Desktop (please complete the following information):

  • OS: MacOS Ventura 13.5 (22G74)
  • Browser Chrome, IPFS - Desktop
  • Version Version 115.0.5790.114 (Official Build) (arm64), webui: a43dd23

Additional context
It looks like it should be fairly straightforward to remove pdf-view updates from the rendering cycle.

@whizzzkid whizzzkid added the need/triage Needs initial labeling and prioritization label Aug 2, 2023
@welcome
Copy link

welcome bot commented Aug 2, 2023

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@whizzzkid whizzzkid changed the title PDF Viewer Refreshes when interacting with webuo PDF Viewer Refreshes when interacting with webui Aug 3, 2023
@whizzzkid whizzzkid added kind/bug A bug in existing code (including security flaws) area/screen/files Issues related to Files screen topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design kind/enhancement A net-new feature or improvement to an existing feature topic/perf Performance need/analysis Needs further analysis before proceeding and removed need/triage Needs initial labeling and prioritization labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/screen/files Issues related to Files screen kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design topic/perf Performance
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

1 participant