Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peers: surface more "identify" info, such as "agentVersion" #2086

Open
lidel opened this issue Jan 23, 2023 · 1 comment
Open

Peers: surface more "identify" info, such as "agentVersion" #2086

lidel opened this issue Jan 23, 2023 · 1 comment
Labels
area/screen/peers Issues related to Peers screen effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature need/maintainer-input Needs input from the current maintainer(s) P2 Medium: Good to have, but can wait until someone steps up topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design

Comments

@lidel
Copy link
Member

lidel commented Jan 23, 2023

We already show some info, for example "Open Streams" column on the peers screen, but it only shows active streams, not all supported protocols and versions:

Screenshot 2023-01-23 at 19-11-17 Peers IPFS

An useful info would be to show AgentVersion from identify protocol. It is already supported, but requires ipfs.id(peerid) call for every peer:

$ ipfs id --enc=json 12D3KooWNCogGjemMiMjZmDxyVcrjP3KW7VFdSPTTGousXEhczuq | jq
{
  "ID": "12D3KooWNCogGjemMiMjZmDxyVcrjP3KW7VFdSPTTGousXEhczuq",
  "PublicKey": "CAESILgL3TiUmYeBy46Uzp0XZxwP4fcFVTIoX6ncvEr+hKSU",
  "Addresses": [
    "/ip4/127.0.0.1/tcp/4001/p2p/12D3KooWNCogGjemMiMjZmDxyVcrjP3KW7VFdSPTTGousXEhczuq",
    "/ip4/127.0.0.1/udp/4001/quic/p2p/12D3KooWNCogGjemMiMjZmDxyVcrjP3KW7VFdSPTTGousXEhczuq",
    "/ip4/172.17.0.2/tcp/4001/p2p/12D3KooWNCogGjemMiMjZmDxyVcrjP3KW7VFdSPTTGousXEhczuq",
    "/ip4/172.17.0.2/udp/4001/quic/p2p/12D3KooWNCogGjemMiMjZmDxyVcrjP3KW7VFdSPTTGousXEhczuq",
    "/ip4/95.208.80.171/tcp/4001/p2p/12D3KooWNCogGjemMiMjZmDxyVcrjP3KW7VFdSPTTGousXEhczuq",
    "/ip4/95.208.80.171/udp/4001/quic/p2p/12D3KooWNCogGjemMiMjZmDxyVcrjP3KW7VFdSPTTGousXEhczuq",
    "/ip6/::1/tcp/4001/p2p/12D3KooWNCogGjemMiMjZmDxyVcrjP3KW7VFdSPTTGousXEhczuq",
    "/ip6/::1/udp/4001/quic/p2p/12D3KooWNCogGjemMiMjZmDxyVcrjP3KW7VFdSPTTGousXEhczuq"
  ],
  "AgentVersion": "go-ipfs/0.8.0/ad14c3932e",
  "ProtocolVersion": "ipfs/0.1.0",
  "Protocols": [
    "/ipfs/bitswap",
    "/ipfs/bitswap/1.0.0",
    "/ipfs/bitswap/1.1.0",
    "/ipfs/bitswap/1.2.0",
    "/ipfs/id/1.0.0",
    "/ipfs/id/push/1.0.0",
    "/ipfs/ping/1.0.0",
    "/libp2p/circuit/relay/0.1.0",
    "/p2p/id/delta/1.0.0",
    "/x/"
  ]
}

Required dependency

I filled ipfs/kubo#9578 to make it a single request:
ipfs swarm peers --enc=json --identify

When we have that feature in Kubo, we could update ipfs-webui and show AgentVersion on Peers screen.

@lidel lidel added need/triage Needs initial labeling and prioritization area/screen/peers Issues related to Peers screen labels Jan 23, 2023
@whizzzkid whizzzkid added P2 Medium: Good to have, but can wait until someone steps up topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature exp/beginner Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours need/maintainer-input Needs input from the current maintainer(s) and removed need/triage Needs initial labeling and prioritization labels Jan 26, 2023
@whizzzkid
Copy link
Contributor

@lidel thanks for posting this. I think we use this as an opportunity to fetch all the information related to peers and allow users to configure what columns they would like to see? Maybe this could be part of the UX enhancements @juliaxbow was mocking out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/screen/peers Issues related to Peers screen effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature need/maintainer-input Needs input from the current maintainer(s) P2 Medium: Good to have, but can wait until someone steps up topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

2 participants