Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting Public Gateway but it ignores my custom port in url and returns error #2077

Open
mrhaoxx opened this issue Dec 18, 2022 · 4 comments
Labels
exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature kind/support A question or request for support need/analysis Needs further analysis before proceeding need/maintainer-input Needs input from the current maintainer(s) P2 Medium: Good to have, but can wait until someone steps up topic/dependencies Topic dependencies

Comments

@mrhaoxx
Copy link

mrhaoxx commented Dec 18, 2022

Describe the bug
when i configure the webui,i has a self-hosted public gateway eposing in a url with custom port
"https://ipfs.xxx.com:1234"
but when i submit url, it ignored my port and becomes "https://ipfs.xxx.com"

@mrhaoxx mrhaoxx added the need/triage Needs initial labeling and prioritization label Dec 18, 2022
@welcome
Copy link

welcome bot commented Dec 18, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@whizzzkid
Copy link
Contributor

@haoxingxing thanks for submitting the issue, I think some effort would be needed to reproduce this. On initial look it might be a bug with multiformats lib which might be assuming no additional ports with https (defaults to 443). This is a weird edge case, would you like to investigate and submit a PR for this issue?

@whizzzkid whizzzkid added exp/intermediate Prior experience is likely helpful P2 Medium: Good to have, but can wait until someone steps up topic/dependencies Topic dependencies kind/enhancement A net-new feature or improvement to an existing feature kind/support A question or request for support need/maintainer-input Needs input from the current maintainer(s) need/analysis Needs further analysis before proceeding and removed need/triage Needs initial labeling and prioritization labels Dec 19, 2022
@mrhaoxx
Copy link
Author

mrhaoxx commented Dec 19, 2022

I knew little about js so it might be difficult for me to direct contribute to the code.

But i think the issue is a local problem because it is normal to set the ipfs api address with custom port
the two settings (api/public gateway) should have similar processing logic but one is normal and the other not

@mrhaoxx
Copy link
Author

mrhaoxx commented Dec 19, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature kind/support A question or request for support need/analysis Needs further analysis before proceeding need/maintainer-input Needs input from the current maintainer(s) P2 Medium: Good to have, but can wait until someone steps up topic/dependencies Topic dependencies
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

2 participants