Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning multiple files when adding multiple files like Kubo #1946

Open
tkb2501 opened this issue Jun 21, 2023 · 1 comment
Open

Pinning multiple files when adding multiple files like Kubo #1946

tkb2501 opened this issue Jun 21, 2023 · 1 comment
Assignees
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@tkb2501
Copy link

tkb2501 commented Jun 21, 2023

Hi Team,

I'm trying to add multiple files simultaneously in IPFS-cluster node but the issue is that only a single CID is being pinned to the cluster while other CIDs are not getting pinned.

Although I'm able to access those files using GET api call but why it isn't pinning all the CIDs?

@tkb2501 tkb2501 added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Jun 21, 2023
@hsanjuan hsanjuan added P1 High: Likely tackled by core team if no one steps up exp/expert Having worked on the specific codebase is important effort/days Estimated to take multiple days, but less than a week and removed need/triage Needs initial labeling and prioritization labels Jun 27, 2023
@hsanjuan
Copy link
Collaborator

Per https://discuss.ipfs.tech/t/pinning-issue-while-adding-multiple-files/16612/2?u=hector, only the last file added in a multipart request is pinned.

I'm not sure why it was done this way. I can speculate that there is no good way to differentiate between adding a folder with files and adding many files. When adding a folder that has files inside, then only the last root CID should be pinned, and not every single part of the multipart should be pinned. I am not sure how Kubo makes a difference here but we should replicate the behaviour.

@hsanjuan hsanjuan self-assigned this Jun 27, 2023
@hsanjuan hsanjuan changed the title IPFS pinning error Pinning multiple files when adding multiple files like Kubo Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

No branches or pull requests

2 participants