Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast state cleanup for crdt #1698

Open
hsanjuan opened this issue Jun 15, 2022 · 0 comments
Open

Fast state cleanup for crdt #1698

hsanjuan opened this issue Jun 15, 2022 · 0 comments
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@hsanjuan
Copy link
Collaborator

The crdt module Clean() method tries to clean the badger datastore politely, respecting the namespace with crdt data. This becomes very slow.

The ipfs-cluster-service state cleanup command is meant to delete all the data anyway so it could just rm -rf badger:

ipfs-cluster/cmdutils/state.go

Line 185 in 4271187

return crdt.Clean(context.Background(), crdtsm.cfgs.Crdt, store)

@hsanjuan hsanjuan added status/ready Ready to be worked P1 High: Likely tackled by core team if no one steps up exp/beginner Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours labels Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hsanjuan