Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adding a CAR file should keep allocations #1441

Open
hsanjuan opened this issue Aug 9, 2021 · 0 comments
Open

Re-adding a CAR file should keep allocations #1441

hsanjuan opened this issue Aug 9, 2021 · 0 comments
Labels
effort/hours Estimated to take one or several hours exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@hsanjuan
Copy link
Collaborator

hsanjuan commented Aug 9, 2021

iirc, allocations when adding a file are decided up-front. Since there is no CID, we do not know if the item is pinned and therefore existing allocations are not re-used.

Now, with CAR files, we do have a root CID up-front, so we could at the very least send the blocks to the places that should already have them and not re-allocate the whole pin.

@hsanjuan hsanjuan added kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up exp/expert Having worked on the specific codebase is important effort/hours Estimated to take one or several hours labels Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

1 participant