Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom SecretManagers #1809

Open
DeppLearning opened this issue Jan 4, 2024 · 2 comments
Open

Enable custom SecretManagers #1809

DeppLearning opened this issue Jan 4, 2024 · 2 comments
Labels
m-client Module - Client t-refactor Task - Refactor

Comments

@DeppLearning
Copy link

Description

This issue still persists: #407 . The closing PR #462 mentioned the issue of using custom secret managers wasn't resolved yet, still the issue was closed.

Motivation

The available variants in the SecretManager enum are not enough, and it would help adoption if there would be a generic api that others can implement without needing to fork.

Requirements

Open questions (optional)

Are you planning to do it yourself in a pull request?

Maybe

@thibault-martinez
Copy link
Member

Hi @DeppLearning, it was closed because it will not be addressed on 1.0 and is already being implemented on 2.0.

@thibault-martinez thibault-martinez added m-client Module - Client t-refactor Task - Refactor labels Jan 8, 2024
@thibault-martinez thibault-martinez added this to the v2.0.0 milestone Jan 8, 2024
@DeppLearning
Copy link
Author

Hi @DeppLearning, it was closed because it will not be addressed on 1.0 and is already being implemented on 2.0.

Oh I missed that, thank you for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m-client Module - Client t-refactor Task - Refactor
Projects
Status: Product Backlog
Development

No branches or pull requests

2 participants