Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Settings and SyncManager #686

Open
piotrm50 opened this issue Jan 23, 2024 · 0 comments
Open

Refactor Settings and SyncManager #686

piotrm50 opened this issue Jan 23, 2024 · 0 comments
Labels
nice-to-have team-consensus Issues for Consensus Team team-node Issues for Node Team

Comments

@piotrm50
Copy link
Collaborator

We should re-think Settings and the SyncManager altogether imo.
Currently, Settings is a weird mix of the state of an engine and its configuration. This becomes quite clear when looking at its Export method. Where we only export

  • latest commitment
  • latest finalized slot (is this even good? as it might lead to different snapshots (when comparing directly or just hashes) as it incorporates a subjective measure. maybe it should be the finalized slot at the export slot or something)
  • protocol versions
  • future protocol parameters
  • protocol parameters

All the rest is more of a state.

As for the SyncManager this is more like a state of the engine. In a future PR we should probably move all state related properties to the SyncManager, maybe consider renaming it and implement a reactive wrapper around kvstore.TypedValue for convenience access and subscription to changes.

Originally posted by @jonastheis in #680 (review)

@piotrm50 piotrm50 added team-consensus Issues for Consensus Team team-node Issues for Node Team nice-to-have labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice-to-have team-consensus Issues for Consensus Team team-node Issues for Node Team
Projects
Status: Product Backlog
Development

No branches or pull requests

1 participant