Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Safe Area Height in iPhone X #76

Open
MrJai opened this issue May 16, 2018 · 1 comment
Open

Additional Safe Area Height in iPhone X #76

MrJai opened this issue May 16, 2018 · 1 comment

Comments

@MrJai
Copy link

MrJai commented May 16, 2018

Hi, thanks for such an amazing view controller that saved me many hours of work, and it works great. I just face one issue recently and that is specific to iPhone X.

There is additional 34 pixel at the bottom of screen when running on iPhone X. You can see the same in the sample maps app. There should be an option to choose from if a developer wants bottom of super view to be the reference or bottom of safe area to be the reference.

If you think there can be a way around to fix it, then please help me out.

@matthewharries
Copy link

I agree! For now I just did the following to calculate my height return tableView.contentSize.height + (UIApplication.shared.keyWindow?.safeAreaInsets.bottom ?? 0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants