New Features #18
Open
New Features #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexsteinerde, Thank you for your PR. We greatly appreciate your contribution. However, we strive to keep diffs and PRs as small as possible. Large diffs require developers using this component to check more code when updating the dependency. Would you mind reverting your code style changes and adhere to the code style of this repository to minimise the diff? |
|
@felixLam I reverted some changes to make the number of diffs as small as possible. At every new code I use the new style code now but this changes already produced diffs in the code. |
|
I would appreciate an acceptance of this pull request. Or if you have any other requirements, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I added some new features to the library that I need for myself.
I would appreciate it if you accept this request so others can also use the new features of changing the size and background color of a specific item.
It would also be great if you push the new podspec file to the default repository.
fixes #17
Thanks for your great work.