New mechanics and functions for TravianC (Travian Crazy) and refactoring #524
Comments
|
Nice, great job :)! |
|
Yes, i already fixed it in a previous commit, i forgot to mark it as closed. |
|
well this is a good prespective. but i think in my opinion this "travianC" must be an option in the install, like travian official quest vs travianZ quest. also i think in first rule must be fix all "oficcial" game bugs and associate all translations to one file, for the other people like me for example, can translate the whole game into native languages and add here to be included in this version. after the whole oficial game was tested and bugless keep working on that extra functions leaving to admin the choice off active them or not.. the big percentage off players here only want put the oficial game working fully and play with friends on a small server.. this only my opinion :) |
|
@eliopinho As far as I understand it correctly, it will be an ordinary TravianZ with the ability to include one or another function that will expand the possibility of the usual version) From the box this script should come with the functionality of the usual T3.6 travian. @iopietro @Shadowss Some things like here and in another similar issue with bugs have both things that extend functionality and that relate directly to the usual version of T3.6. I propose to review these two issue and the gap in the separate things that complement the functionality and should be included separately and the things that are bugs. P.S. I hope that Google correctly translated what I wanted to express in my thoughts :) |
|
@eliopinho @velhbxtyrj, Yeah, I agree, new functions should be separated from bug fixing, that's why I'll first try to fix all bugs of this version and then start to add new functionality to the game (and the admin of the server will be able to choose what functionality activate and what not). Current "road map":
|
|
So I'll do it today. Then we will have the information even clearer. |
|
Thanks :). |
|
I just do not remember about the vacation mode. Was it implemented in T4+? Transfer it to refactor or leave it in bugs? |
|
If i remember correctly, it wansn't in the T3.6 version, they introduced it in the T4.2/T4.4, you can transfer it. |
|
I hope that I transferred everything to the places where it should be. |
|
Peace system picture message : https://user-images.githubusercontent.com/5437151/38741765-96f7a462-3f32-11e8-90ee-20149b1ae3f4.jpg Artifact system picture message : https://user-images.githubusercontent.com/5437151/38771387-5c1b3884-401a-11e8-95f2-06599cc08b14.jpg |
|
@iopietro @Shadowss I delete some of the items here, since they are duplicated in another issue and refer to bugs:
|
|
You did well :). |
|
@iopietro On the newly installed server, everything works fine. Everything turns on and off. Why can not this be done on the old server? And still, I ask you, if you have free time, to view these files for errors.
|
|
I think that because old servers don't have it written in the settings, I'll look carefully those errors. |
|
But I independently registered this parameter in the config. And after I tried to change it, this record just went away and in the game it's always on. Even if it's disabled in the config, and change any other partition, then the entry is also deleted and becomes always on. I also noticed that if we have an old server, then for this to work it is necessary for us to add the record by ourselves on this path and everything will work as expected (file is called constant_format.tpl): https://github.com/Shadowss/TravianZ/tree/master/GameEngine/Admin/Mods In this code, the file is now missing constant_format.tpl. But when the server is installed then this file is available on the server and when I registered the same entry in it as in this file https://github.com/Shadowss/TravianZ/blob/master/install/data/constant_format.tpl everything started working as and expected. It can be what that error that record there did not get automatically during configuration of settings? Or is it necessary to write to this file yourself for the code to work on the old server? |
|
I do think so, constant_format and all files of the admin panels that edit config.php should be edited. |
|
So it turns out that I did everything right. Today, I edited the files a little bit more that would eliminate fatal errors while editing other configuration sections. Can it make sense to try to unite these files here? And one more thing about this. I created the second profile file (old file overview.tpl and new file newOverview.tpl). What is the best solution in this case? Leave one file and in it to do a conclusion of the different information or it will be better two different files? |
|
Yep, it makes sense, it can be optimized by merging those single files in a unique one. It would be better leaving only one file with an "if" that decides (by confronting the constant in the config.php file) if oases should be showed or not. |
+Enable (Disable) New forum post message
+Enable (Disable) Tribes images in profile
+Enable (Disable) MHs images in profile
+Enable (Disable) Display artifact in profile
+Minor changes
NOTE 1: To play this version of the game, you need to reinstall
the server OR you can simply add these lines of code into your file:
ameEngine/config.php
define("NEW_FUNCTIONS_FORUM_POST_MESSAGE", False);
define("NEW_FUNCTIONS_TRIBE_IMAGES", False);
define("NEW_FUNCTIONS_MHS_IMAGES", False);
define("NEW_FUNCTIONS_DISPLAY_ARTIFACT", False);
GameEngine/Admin/Mods/constant_format.tpl
define("NEW_FUNCTIONS_FORUM_POST_MESSAGE", %NEW_FUNCTIONS_FORUM_POST_MESSAGE%);
define("NEW_FUNCTIONS_TRIBE_IMAGES", %NEW_FUNCTIONS_TRIBE_IMAGES%);
define("NEW_FUNCTIONS_MHS_IMAGES", %NEW_FUNCTIONS_MHS_IMAGES%);
define("NEW_FUNCTIONS_DISPLAY_ARTIFACT", %NEW_FUNCTIONS_DISPLAY_ARTIFACT%);
NOTE 2: pay special attention to the fact that these are two
different records !!! If the records are entered incorrectly,
you will receive a non-working code!
|
@iopietro I found three commits (more precisely I hope that it is those commits that changed the logic of the alliance): But for me it's a little incomprehensible that I would make a division into old code and a new code to enable and disable as a new function. I could take the old code and add it to the if else: but it seems to me that this will be wrong and can cause some errors that could be corrected or something else. |
|
For now, I removed it in the refactored version, but it'll be rewritten from scratch later. |
This new mechanics has already been implemented. But need to make it customizable (enable and disable during installation and in the Admin panel).
The new mechanics and functions are already implemented and enabled (disabled) during the installation and in the admin panel
General Improovements
Other Improovements
The text was updated successfully, but these errors were encountered: