Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: missing root element's scope id as classname in user provided children #5749

Closed
3 tasks done
yigityuce opened this issue May 10, 2024 · 2 comments
Closed
3 tasks done

bug: missing root element's scope id as classname in user provided children #5749

yigityuce opened this issue May 10, 2024 · 2 comments
Labels
triage

Comments

@yigityuce
Copy link
Contributor

Prerequisites

Stencil Version

4.18.0

Current Behavior

as you already know #5702 issue fix is already merged & shipped with v4.18.0. However, I realised I missed to add parent scope id to the relocated elements which are provided from the application level (not in VDom). Therefore, elements that are provided from the app level (simple DOM) are not able to be customized by the css selector from the parent component.

P.S: I reused the existing reproduction repo by updating it. Here you can find the updates.

Current Output:
image

Expected Behavior

image

System Info

System: node 22.1.0
    Platform: darwin (23.4.0)
   CPU Model: Apple M3 Pro (12 cpus)
    Compiler: /Users/yigit.yuce/Documents/Projects/personal/yigityuce.github/stencil/compiler/stencil.js
       Build: 1715335653
     Stencil: 4.18.0-dev.1715335653.31259a5 🐎
  TypeScript: 5.4.5
      Rollup: 2.56.3
      Parse5: 7.1.2
      jQuery: 4.0.0-pre
      Terser: 5.30.4

Steps to Reproduce

pls see the diff and run the latest version of reproduction repo

yigityuce/stencil-v4-sc-nested-css-scope-id@99dc6e0

Code Reproduction URL

https://github.com/yigityuce/stencil-v4-sc-nested-css-scope-id

Additional Information

No response
@ionitron-bot ionitron-bot bot added the triage label May 10, 2024
yigityuce added a commit to yigityuce/stencil that referenced this issue May 10, 2024
@yigityuce
fix(runtime): add root scope id to the user provided nested children …
f434429 
…as classname

ionic-team#5749
@yigityuce yigityuce mentioned this issue May 10, 2024
Merged
2 tasks
github-merge-queue bot pushed a commit that referenced this issue May 13, 2024
@yigityuce @christian-bromann
fix(runtime): add root scope id to the user provided nested children …
e864132 
…as classname (#5750)

* fix(runtime): add root scope id to the user provided nested children as classname

#5749

* fix(runtime): add missing insertBefore patches

---------

Co-authored-by: Christian Bromann <git@bromann.dev>
@alicewriteswrongs
Copy link
Member

this was closed in #5750 and the fix will be released today!

@alicewriteswrongs
Copy link
Member

The fix for this issue has been released as a part of today's Stencil v4.18.1 release!

@yigityuce yigityuce mentioned this issue May 17, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yigityuce @alicewriteswrongs