bug: autofocus prop/attr is defined on other HTML attribute types instead of HTMLAttributes
#5726
Closed
3 tasks done
Labels
Bug: Validated
This PR or Issue is verified to be a bug within Stencil
Comments
|
Hey @jcfranco 👋 Thanks for the bug report! I wasn't able to see the build failure you were describing, but was able to see errors in my editor related to the type checker (see the screenshot below). Regardless, I think this is a reasonable request/bug/thing we can fix. I see #5727 - I'll discuss that with the team internally today. Thanks again! |
rwaskiewicz
added
the
Bug: Validated
jcfranco
added a commit
to Esri/calcite-design-system
that referenced
this issue
May 3, 2024
…-mode` and `input-mode` attributes (#9245) **Related Issue:** #9235 ## Summary This fixes the following issues introduced by #9123 when component props that shadowed global attributes were removed: * the kebab-cased attribute names of those props would no longer work (namely, `enter-key-mode`, `input-mode`) * `autofocus` was missing from component types as Stencil does not include it in the base `HTMLAttribute` type (see ionic-team/stencil#5726).
jcfranco
added a commit
to Esri/calcite-design-system
that referenced
this issue
May 10, 2024
…-mode` and `input-mode` attributes (#9245) **Related Issue:** #9235 ## Summary This fixes the following issues introduced by #9123 when component props that shadowed global attributes were removed: * the kebab-cased attribute names of those props would no longer work (namely, `enter-key-mode`, `input-mode`) * `autofocus` was missing from component types as Stencil does not include it in the base `HTMLAttribute` type (see ionic-team/stencil#5726).
jcfranco
added a commit
to Esri/calcite-design-system
that referenced
this issue
May 10, 2024
…-mode` and `input-mode` attributes (#9245) (#9306) **Related Issue:** #9235 ## Summary This fixes the following issues introduced by #9123 when component props that shadowed global attributes were removed: * the kebab-cased attribute names of those props would no longer work (namely, `enter-key-mode`, `input-mode`) * `autofocus` was missing from component types as Stencil does not include it in the base `HTMLAttribute` type (see ionic-team/stencil#5726). Co-authored-by: Ben Elan <no-reply@benelan.dev>
jcfranco
added a commit
to Esri/calcite-design-system
that referenced
this issue
May 15, 2024
…n HTMLElement (#9343) **Related Issue:** #9235 ## Summary Exposes `autofocus` property to ensure the prop/attr is available on the `HTMLElement` type. This should no longer be necessary once ionic-team/stencil#5726 is fixed and available in Stencil.
6 tasks
benelan
pushed a commit
to Esri/calcite-design-system
that referenced
this issue
May 15, 2024
…n HTMLElement (#9343) **Related Issue:** #9235 ## Summary Exposes `autofocus` property to ensure the prop/attr is available on the `HTMLElement` type. This should no longer be necessary once ionic-team/stencil#5726 is fixed and available in Stencil.
benelan
added a commit
to Esri/calcite-design-system
that referenced
this issue
May 15, 2024
…n HTMLElement (#9343) (#9347) **Related Issue:** #9235 ## Summary Exposes `autofocus` property to ensure the prop/attr is available on the `HTMLElement` type. This should no longer be necessary once ionic-team/stencil#5726 is fixed and available in Stencil. Co-authored-by: JC Franco <jfranco@esri.com>
|
A fix for this was included in today's v4.18.2 release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Stencil Version
4.17.2
Current Behavior
Setting the global
autofocusattribute/prop will cause TypeScript to complain about missing definition.The following codepen shows that custom elements inherit it from
HTMLElement.Expected Behavior
For
autofocusprop/attr to be included in the base Stencil HTML attr/prop types.System Info
No response
Steps to Reproduce
Follow provided steps in repro case.
Code Reproduction URL
https://github.com/jcfranco/stencil-autofocus-missing-on-base-html-attr-type
Additional Information
This could apply to other global attributes.
The text was updated successfully, but these errors were encountered: