Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm and yarn DO NOT install ion-android* icons (bower works just fine!) #492

Closed
zooduck opened this issue Jun 17, 2017 · 7 comments
Closed

Comments

@zooduck
Copy link

zooduck commented Jun 17, 2017

Both npm and yarn do not install the ion-android icons (bower works just fine, but its deprecated so we shouldn't be using it anymore).

I had to download the zipped folder from ionicons.com in the end and use that instead.

@janpio
Copy link

janpio commented Jun 18, 2017

And what version are you talking about? Post your ionic info please.

@zooduck
Copy link
Author

zooduck commented Jun 18, 2017

You are right, this has to do with versioning. Bower installs an earlier version (~2.0.1), which matches the current documentation at ionicons.com.

Since both npm and yarn install ^3.0.0. by default, it would make sense for ionicons.com to forward to the latest docs at https://ionicframework.com/docs/ionicons/ or at the very least make it clear that the current page contains an out-of-date set of icons.

Surely old versions should be archived and linked, not the default?

New docs are way better btw =D

@janpio
Copy link

janpio commented Jun 18, 2017

I ask you again:
And what version are you talking about?
Post your ionic info please.

You talking about Bower makes me think you are not even using the version of Ionic this repository is about.

@zooduck
Copy link
Author

zooduck commented Jun 18, 2017

I did mention the specific versions in my last comment, but I will list the DEFAULT versions that get installed for each package manager:

bower install ionicons: v2.0.1
npm install ionicons: v3.0.0
yarn add ionicons: v3.0.0

It's particularly confusing because http://ionicons.com shows the outdated set of icons that you get only with the deprecated bower!

Anyone who installs ionicons using npm or yarn will naturally head over to http://ionicons.com and be presented with an outdated set of icons totally incompatible with their version of ionicons!

Sorry if I did not explain very well before, but hopefully it will make sense to you now.

My suggestion is that http://ionicons.com is updated to show the latest set by default, with links to archived versions (which is pretty much standard practice for all libraries/frameworks).

@janpio
Copy link

janpio commented Jun 18, 2017

You actually did everything all right - I misread the repo name as "ionic"... Sorry.

You are correct, ionicons.com could use some work and love.

@liamdebeasi
Copy link
Contributor

Thanks for the report and apologies for the delay. This should be resolved on the latest version of Ionicons. Additionally, we do have plans to update the Ionicons website to make the usage clearer.

@janpio
Copy link

janpio commented Sep 27, 2022

Sometimes it pays to keep an issue open for 5+ years I see 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants