Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: why its so tough to add icon using npm and angular #1340

Open
rustam-mukhametshin opened this issue Feb 23, 2024 · 2 comments
Open

feat: why its so tough to add icon using npm and angular #1340

rustam-mukhametshin opened this issue Feb 23, 2024 · 2 comments
Labels
triage New issues

Comments

@rustam-mukhametshin
Copy link

Describe Problem

  1. No npm command to install in documentation.
  2. No guide to import ionicons to existing project even if I have ionic already installed.

Describe Preferred Solution

  1. Add npm command to install ionicons
  2. Add simple guide in readme to add icons to Angular, React, Vue, etc

Describe Alternatives

No response

Additional Information

If no one want to do it, let me create PR for that.

@rustam-mukhametshin rustam-mukhametshin added the triage New issues label Feb 23, 2024
@rustam-mukhametshin
Copy link
Author

Ok, let me create PR, I just dont want to wait.
Short Angular guide to add icons to existing project.

@sean-perkins
Copy link
Contributor

sean-perkins commented Mar 8, 2024

Hello @rustam-mukhametshin, thanks for the feedback.

ionicons is its own separate project from Ionic Framework. It does not include its own component wrapper for Angular, as it does when using it from Ionic Framework. The distribution strategy for ionicons currently is to have it act as a ghost dependency in Ionic Framework, so that developers do not have to have ionicons as a project dependency for the component to work in their projects and to work around limitations of using different Stencil projects within the same context. The only thing that installing ionicons independently in an Ionic Framework project does, is that you can reference new icons/SVGs that are available in the later releases from the one distributed with Ionic Framework.

The documentation for using ionicons by itself should not include information about the @ionic/angular package, as they can be used independently (a project can use ionicons without Ionic Framework).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage New issues
Projects
None yet
Development

No branches or pull requests

2 participants