Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create Icons for IOS and BROWSER(favicon) does not work #1995

Closed
jgw96 opened this issue Mar 15, 2017 · 3 comments
Closed

create Icons for IOS and BROWSER(favicon) does not work #1995

jgw96 opened this issue Mar 15, 2017 · 3 comments

Comments

@jgw96
Copy link
Contributor

jgw96 commented Mar 15, 2017

From @mburger81 on March 15, 2017 13:12

Ionic version: (check one with "x")
[ ] 1.x
[x] 2.x

I'm submitting a ... (check one with "x")
[x] bug report
[x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
After creating my icons using ionic resource --splash and ionic resource --icon the cli generates the pictures for splash and icons. As described in this very old bug [https://github.com//issues/1855], where I also add a comment, the pictures are only created for android and not for ios.

The other thing is, what's about the favicon for the browser? Have a look in the config.xml after creating pictures with cli, I see this new entry
<icon src="resources/android/icon/drawable-xhdpi-icon.png"/>
I think this should be the pictures which will be used instead of the favicon, but this does not work.

Expected behavior:

  1. Please close the CLI bug for creating also the IOS pictures.
  2. If the pictures from android resource configured as icon in config.xml should be the favicon for browser, it does not work. If this should be the picture for PWA icons, I think the created pictures for browser and PWA could and should be the same.
  3. If I misunderstand anything, this should also be a feature request :) Please create also favicon on creating resource

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

Cordova CLI: 6.5.0 
Ionic Framework Version: 2.2.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.4
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Linux 4.8
Node Version: v6.10.0
Xcode version: Not installed

Copied from original issue: ionic-team/ionic-framework#10787

@jthoms1
Copy link
Member

jthoms1 commented Mar 16, 2017

The issues for ios creation has been resolved in CLI v3 beta. The favicon for web is something that we plan on adding in the future but it will likely be closer tied to our pwa/web plugins instead of cordova. Let me know if you have any other questions. Thanks!

@jthoms1 jthoms1 closed this as completed Mar 16, 2017
@mburger81
Copy link

Ok, I think favicon for web is something nice to have and it does not cost a lot.
btw when do release the next cli3 beta which close this bug #1973 we are still waiting for the bug fix to test your new cli :)
Tomorrow was three days ago :) JOKE

@jthoms1
Copy link
Member

jthoms1 commented Mar 16, 2017

Today it will be released. 😄 I think the favicon is something we all want just trying to identify the right way to integrate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants