Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When course deletion is executed by giving course deletion authority to the organization administrator, the confirmation screen lang is not displayed. #1961

Open
reso-nitta opened this issue Apr 11, 2024 · 1 comment

Comments

@reso-nitta
Copy link

reso-nitta commented Apr 11, 2024

Environment
iomad:4.1.9
We changed settings so that CompanyManager can delete courses.
The following three Capability were set up for the CompanyManager.

View company courses
block/iomad_company_admin:viewcourses

Delete a non-shared company course
block/iomad_company_admin:deletecourses

Manage IOMAD course settings for all companies and courses
block/iomad_company_admin:manageallcourses

Log in as the organization administrator and perform the course deletion from the "Manage IOMAD course settings" screen.
A confirmation screen appears but no lang is displayed.

CompanyManager confirmation screen
CompanyManager

The site administrator's confirmation screen will show lang.
Administrator's confirmation screen
admin

After checking, I believe the following source may be the cause.

iomad/blocks/iomad_company_admin/iomad_courses_form.php
Line 157.
$message = get_string('deleteacoursesfull', 'block_iomad_company_admin', $course->fullname);

The following lang file says 'deletecoursesfull'.

iomad/blocks/iomad_company_admin/lang/en/block_iomad_company_admin.php
Line 251.
$string['deletecoursesfull'] = 'Are you sure you want to delete course {$a}? Clicking continue will remove all current user enrolments, any license allocations and the course from the company. <b>There is no recovery from this without backup</b>';
@reso-nitta
Copy link
Author

Is there any problem with the above modification method?

Are there any plans for future modifications?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant