Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas : Hide company selector in header and Inherit parent company custom appearance on creation #1950

Open
LeonidasFRA opened this issue Mar 26, 2024 · 6 comments

Comments

@LeonidasFRA
Copy link

Hello,

I have 2 suggestions that would be handy for many admins (I guess).

  1. You have added a company selector in the header, it's a great feature if the user is used in several companies, however I don't think it's relevant to actualy display it if the user is only into one company. (Maybe add an option to hide it if only in one company)

  2. When clicking on "create child company" from the Manage company tab, it be relevant not to only grab the different logos, but also the custom CSS/colors/Custom menu items (and certificate design if it's not already the case).

@LeonidasFRA
Copy link
Author

Also the restriction based upon being part of a company could also have an option to allow members of child companies to have access to the restricted content. It might make restrictions easier to handle.

In example, since every companies are sharing the same home page, i'm using the restrict access by filtering companies. But anytime I would add a child company I would have to edit each restriction (and it could be source of errors and mistakes).
So having this option my mind would be freed haha

@sgvfr
Copy link

sgvfr commented Mar 26, 2024

Nested companies don't show in the drop down. Maybe a flout can be added for that?

@CesparRes
Copy link

CesparRes commented Mar 27, 2024

It would also be nice to have an option to hide this header "companymenu" display because in our particular site, it doesnt look good at all.

For now we've simply removed the code from "company_info_popover.mustache" to hide this selector menu - because it's permanently displayed even when a user is only in a single company.

@turf212
Copy link
Collaborator

turf212 commented Mar 29, 2024

It would be easier to hide it in the CSS rather than changing the code. So something like:

.navbar.fixed-top .companymenu{ display:none;}
would work.

Interesting ideas for the company restriction and defaults for child companies when creating them.

@LeonidasFRA
Copy link
Author

Well, hiding it for everyone will fix @CesparRes problem, but for me it might not be the solution. Since people in the same company might have the need to see the company selector, and others might not. I guess other people could encounter the same issue.

@CesparRes
Copy link

For us it just looked bad as it was using the wrong company logo (or rather the variation that just didn't look right on the background of the header bar) - also it seems redundant to have it when the user is only in a single company.

I guess more customisation options for it, and to hide it when it's not needed would help.

Will look at adding the custom css to hide it instead of code change though - if only because it's frustrating to constantly put code changes back in at updates 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants