Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]: Block write to foreign R/O states #2665

Open
1 task done
mcm1957 opened this issue Apr 3, 2024 · 1 comment
Open
1 task done

[enhancement]: Block write to foreign R/O states #2665

mcm1957 opened this issue Apr 3, 2024 · 1 comment

Comments

@mcm1957
Copy link
Contributor

mcm1957 commented Apr 3, 2024

No existing issues.

  • There is no existing issue for my request.

Description

I suggest to block writing to FOREIGN states with attribute write:false.

Adapter code should only be allowed to write to OWN RO states nd to some general purpose areas like 0_userdate_0. This would enhance code quality and block bad written adapters to write to states where the can confuse the complete system (i.e. admin.x.info.updatesJson).

Why?

see description

Suggestion would ensure that random / illegal writes are blocked and errors resulting from such actions are minimized thus improving stability. As (as far as I have been told) a warning ist already output, changing this to blocking should not cause any noticeable overhead.

How?

No response

@foxriver76
Copy link
Collaborator

One example to not do this: hm-rega writes read-only states in hm-rpc namespace and it is valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants