Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails on XML comments #18

Closed
io7m opened this issue Jan 15, 2022 · 0 comments
Closed

Fails on XML comments #18

io7m opened this issue Jan 15, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@io7m
Copy link
Owner

io7m commented Jan 15, 2022

The new 7.0 and 8.0 stylesheets have a fallback template that raises an error. This is intended to ensure that there are no silent failures; if an element isn't matched by a template, then processing should fail. Unfortunately, this fallback rule also catches XML comments! Any document containing XML comments will fail.

@io7m io7m added the bug Something isn't working label Jan 15, 2022
@io7m io7m self-assigned this Jan 15, 2022
io7m added a commit that referenced this issue Feb 3, 2022
This fixes an issue where comments in a file would cause processing
to fail.

Affects: #18
@io7m io7m closed this as completed Feb 3, 2022
io7m added a commit that referenced this issue Feb 3, 2022
Release: com.io7m.xstructural 1.4.0

Change: Fix a bug where documents with comments would be rejected (Ticket: #18)
Change: Ensure existing files are replaced when producing EPUBs (Ticket: #20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant