Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZFS create called incorrectly for volumes #28

Closed
io7m opened this issue Jul 28, 2020 · 0 comments
Closed

ZFS create called incorrectly for volumes #28

io7m opened this issue Jul 28, 2020 · 0 comments
Assignees
@io7m
Labels
bug Something isn't working

Comments

@io7m
Copy link
Owner

io7m commented Jul 28, 2020

Realizing a VM results in this command being executed:

/sbin/zfs create -V 12800000000 /storage/vm/50613ad2-3c93-478b-afa0-d8ac613723da/disk-0_1_0

The problem is that an absolute path /storage/vm/... is being used, but the actual path should be a ZFS filesystem path. In this specific case, that would mean: zroot/storage/vm/50613ad2-3c93-478b-afa0-d8ac613723da/disk-0_1_0 instead. This requires fetching the underlying FileStore as is done elsewhere in the codebase.
@io7m io7m added the bug Something isn't working label Jul 28, 2020
@io7m io7m self-assigned this Jul 28, 2020
@io7m io7m closed this as completed in 2330b5b Jul 28, 2020
io7m added a commit that referenced this issue Jul 28, 2020
@io7m
Merge branch 'release/0.0.4'
eb160f5 
Release: com.io7m.waxmill 0.0.4
Change: Fix issue creating ZFS volumes (Ticket: #28)
io7m added a commit that referenced this issue Jul 28, 2020
@io7m
Merge tag 'com.io7m.waxmill-0.0.4' into develop
310a50d 
Release: com.io7m.waxmill 0.0.4

Change: Fix issue creating ZFS volumes (Ticket: #28)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@io7m io7m

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@io7m