New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OK button behaviour is incorrect #34
Comments
For example: Open a file chooser in |
Release: com.io7m.jwheatsheaf 4.0.0-beta0001 Change: (Backwards incompatible) File choosers no longer require a Stage argument. Change: Refactored test suite to use xoanon instead of TestFX. Change: Update com.github.marschall:memoryfilesystem 2.6.0 → 2.6.1. Change: Update com.io7m.primogenitor:com.io7m.primogenitor.support 7.5.0 → 7.7.0. Change: Update org.junit.jupiter:junit-jupiter-api 5.9.2 → 5.9.3. Change: Update org.junit.jupiter:junit-jupiter-engine 5.9.2 → 5.9.3. Change: Update org.openjfx:javafx-controls 19 → 20. Change: Update org.openjfx:javafx-fxml 19 → 20. Change: Update org.openjfx:javafx-graphics 19 → 20. Change: Update org.openjfx:javafx-swing 19 → 20. Change: Update org.junit.jupiter:junit-jupiter-api 5.9.1 → 5.9.2. Change: Update org.junit.jupiter:junit-jupiter-engine 5.9.1 → 5.9.2. Change: Update nl.jqno.equalsverifier:equalsverifier 3.12.3 → 3.14.1. Change: Update org.slf4j:slf4j-api 2.0.6 → 2.0.7. Change: Update ch.qos.logback:logback-classic 1.4.5 → 1.4.6. Change: Update org.mockito:mockito-core 4.10.0 → 5.3.0. Change: Update com.github.marschall:memoryfilesystem 2.4.0 → 2.5.0. Change: (Backwards incompatible) Require JDK 17 Change: Fix a silently failing OK button (Ticket: #34)
Release: com.io7m.jwheatsheaf 4.0.0-beta0001 Change: (Backwards incompatible) File choosers no longer require a Stage argument. Change: Refactored test suite to use xoanon instead of TestFX. Change: Update com.github.marschall:memoryfilesystem 2.6.0 → 2.6.1. Change: Update com.io7m.primogenitor:com.io7m.primogenitor.support 7.5.0 → 7.7.0. Change: Update org.junit.jupiter:junit-jupiter-api 5.9.2 → 5.9.3. Change: Update org.junit.jupiter:junit-jupiter-engine 5.9.2 → 5.9.3. Change: Update org.openjfx:javafx-controls 19 → 20. Change: Update org.openjfx:javafx-fxml 19 → 20. Change: Update org.openjfx:javafx-graphics 19 → 20. Change: Update org.openjfx:javafx-swing 19 → 20. Change: Update org.junit.jupiter:junit-jupiter-api 5.9.1 → 5.9.2. Change: Update org.junit.jupiter:junit-jupiter-engine 5.9.1 → 5.9.2. Change: Update nl.jqno.equalsverifier:equalsverifier 3.12.3 → 3.14.1. Change: Update org.slf4j:slf4j-api 2.0.6 → 2.0.7. Change: Update ch.qos.logback:logback-classic 1.4.5 → 1.4.6. Change: Update org.mockito:mockito-core 4.10.0 → 5.3.0. Change: Update com.github.marschall:memoryfilesystem 2.4.0 → 2.5.0. Change: (Backwards incompatible) Require JDK 17 Change: Fix a silently failing OK button (Ticket: #34)
The current code performs some checks in the
onOKSelected
method of the chooser view controller, and silently does nothing if those checks fail. These checks should not be performed there; the button should not be enabled in the first place if the checks have failed.The text was updated successfully, but these errors were encountered: