Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OK button behaviour is incorrect #34

Closed
io7m opened this issue Oct 31, 2021 · 1 comment
Closed

OK button behaviour is incorrect #34

io7m opened this issue Oct 31, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@io7m
Copy link
Owner

io7m commented Oct 31, 2021

The current code performs some checks in the onOKSelected method of the chooser view controller, and silently does nothing if those checks fail. These checks should not be performed there; the button should not be enabled in the first place if the checks have failed.

@io7m io7m added the bug Something isn't working label Oct 31, 2021
@io7m io7m self-assigned this Oct 31, 2021
@io7m
Copy link
Owner Author

io7m commented Oct 31, 2021

For example: Open a file chooser in CREATE mode. Specify a file selection mode function that only returns true if the target file is a regular file. If the user types the name of a nonexistent file (which they might do if they're looking to create a new file) this will always fail, and resultTarget will be set to an empty list. The subsequent checks that determine if the list is non-empty will fail, and the whole method will return silently.

@io7m io7m closed this as completed in c79188d Feb 13, 2022
io7m added a commit that referenced this issue May 28, 2023
Release: com.io7m.jwheatsheaf 4.0.0-beta0001
Change: (Backwards incompatible) File choosers no longer require a Stage argument.
Change: Refactored test suite to use xoanon instead of TestFX.
Change: Update com.github.marschall:memoryfilesystem 2.6.0 → 2.6.1.
Change: Update com.io7m.primogenitor:com.io7m.primogenitor.support 7.5.0 → 7.7.0.
Change: Update org.junit.jupiter:junit-jupiter-api 5.9.2 → 5.9.3.
Change: Update org.junit.jupiter:junit-jupiter-engine 5.9.2 → 5.9.3.
Change: Update org.openjfx:javafx-controls 19 → 20.
Change: Update org.openjfx:javafx-fxml 19 → 20.
Change: Update org.openjfx:javafx-graphics 19 → 20.
Change: Update org.openjfx:javafx-swing 19 → 20.
Change: Update org.junit.jupiter:junit-jupiter-api 5.9.1 → 5.9.2.
Change: Update org.junit.jupiter:junit-jupiter-engine 5.9.1 → 5.9.2.
Change: Update nl.jqno.equalsverifier:equalsverifier 3.12.3 → 3.14.1.
Change: Update org.slf4j:slf4j-api 2.0.6 → 2.0.7.
Change: Update ch.qos.logback:logback-classic 1.4.5 → 1.4.6.
Change: Update org.mockito:mockito-core 4.10.0 → 5.3.0.
Change: Update com.github.marschall:memoryfilesystem 2.4.0 → 2.5.0.
Change: (Backwards incompatible) Require JDK 17
Change: Fix a silently failing OK button (Ticket: #34)
io7m added a commit that referenced this issue May 28, 2023
Release: com.io7m.jwheatsheaf 4.0.0-beta0001

Change: (Backwards incompatible) File choosers no longer require a Stage argument.
Change: Refactored test suite to use xoanon instead of TestFX.
Change: Update com.github.marschall:memoryfilesystem 2.6.0 → 2.6.1.
Change: Update com.io7m.primogenitor:com.io7m.primogenitor.support 7.5.0 → 7.7.0.
Change: Update org.junit.jupiter:junit-jupiter-api 5.9.2 → 5.9.3.
Change: Update org.junit.jupiter:junit-jupiter-engine 5.9.2 → 5.9.3.
Change: Update org.openjfx:javafx-controls 19 → 20.
Change: Update org.openjfx:javafx-fxml 19 → 20.
Change: Update org.openjfx:javafx-graphics 19 → 20.
Change: Update org.openjfx:javafx-swing 19 → 20.
Change: Update org.junit.jupiter:junit-jupiter-api 5.9.1 → 5.9.2.
Change: Update org.junit.jupiter:junit-jupiter-engine 5.9.1 → 5.9.2.
Change: Update nl.jqno.equalsverifier:equalsverifier 3.12.3 → 3.14.1.
Change: Update org.slf4j:slf4j-api 2.0.6 → 2.0.7.
Change: Update ch.qos.logback:logback-classic 1.4.5 → 1.4.6.
Change: Update org.mockito:mockito-core 4.10.0 → 5.3.0.
Change: Update com.github.marschall:memoryfilesystem 2.4.0 → 2.5.0.
Change: (Backwards incompatible) Require JDK 17
Change: Fix a silently failing OK button (Ticket: #34)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant