Allow Esc key to always close dialog (no file selected) - p3 #14
Assignees
Comments
ghost
changed the title
|
Yep, seems fine. |
io7m
added a commit
that referenced
this issue
May 18, 2021
Release: com.io7m.jwheatsheaf 3.0.0 A big thanks to @DaveJarvis for suggestions, bug reports, and some code contributions! Change: Add the ability to specify custom strings (Ticket: #7) Change: Add the ability to confirm file selections (Ticket: #17) Change: Allow for including ".." in directory listings (Ticket: #23) Change: Improve "select directly" dialog behaviour (Ticket: #29) Change: Fix the size formatter (Ticket: #30) Change: Use the default filesystem by default (Ticket: #21) Change: Add support for glob-based filters (Ticket: #19) Change: Improve filename field behaviour (Ticket: #28) Change: Add an optional home directory button (Ticket: #12) Change: Enable sorting of directory items (Ticket: #22) Change: Allow for setting a default file filter (Ticket: #9) Change: Allow the escape key to close file choosers (Ticket: #14) Change: Allow for specifying an initial filename in choosers (Ticket: #15) Change: Allow for specifying custom dialog titles (Ticket: #8) Change: Make the default filters part of the public API (Ticket: #10)
io7m
added a commit
that referenced
this issue
May 18, 2021
Release: com.io7m.jwheatsheaf 3.0.0 A big thanks to @DaveJarvis for suggestions, bug reports, and some code contributions! Change: Add the ability to specify custom strings (Ticket: #7) Change: Add the ability to confirm file selections (Ticket: #17) Change: Allow for including ".." in directory listings (Ticket: #23) Change: Improve "select directly" dialog behaviour (Ticket: #29) Change: Fix the size formatter (Ticket: #30) Change: Use the default filesystem by default (Ticket: #21) Change: Add support for glob-based filters (Ticket: #19) Change: Improve filename field behaviour (Ticket: #28) Change: Add an optional home directory button (Ticket: #12) Change: Enable sorting of directory items (Ticket: #22) Change: Allow for setting a default file filter (Ticket: #9) Change: Allow the escape key to close file choosers (Ticket: #14) Change: Allow for specifying an initial filename in choosers (Ticket: #15) Change: Allow for specifying custom dialog titles (Ticket: #8) Change: Make the default filters part of the public API (Ticket: #10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Minor issue.
EsckeyExpected: File chooser dialog closes.
Actual: File chooser dialog remains open.
Regardless of what File chooser dialog widget has focus, the Esc key should always close the dialog window, returning an empty list. This is another reason why having a separate dialog to navigate to a new directory is probably not used by other OS-level file choosers: pressing Esc would have to close both dialogs in succession. Easier not to deal with two dialogs.
The text was updated successfully, but these errors were encountered: