/
spotbugs-filter.xml
154 lines (137 loc) · 6.04 KB
/
spotbugs-filter.xml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
<?xml version="1.0" encoding="UTF-8"?>
<FindBugsFilter xmlns="https://github.com/spotbugs/filter/3.0.0">
<Match>
<Or>
<Class name="~com\.io7m\.jvgm\.core\..+\$InitShim"/>
<Class name="~com\.io7m\.jvgm\.core\..+\$Builder"/>
<Class name="com.io7m.jvgm.core.VGMCommandDataBlock"/>
<Class name="com.io7m.jvgm.core.VGMCommandEndOfSoundData"/>
<Class name="com.io7m.jvgm.core.VGMCommandEOF"/>
<Class name="com.io7m.jvgm.core.VGMCommandGameGearPSGStereoWrite"/>
<Class name="com.io7m.jvgm.core.VGMCommandPSGWrite"/>
<Class name="com.io7m.jvgm.core.VGMCommandWait735"/>
<Class name="com.io7m.jvgm.core.VGMCommandWait882"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitLong"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShort0"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShort1"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShort2"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShort3"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShort4"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShort5"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShort6"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShort7"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShort8"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShort9"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShortA"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShortB"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShortC"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShortD"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShortE"/>
<Class name="com.io7m.jvgm.core.VGMCommandWaitShortF"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2413Write"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWait0"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWait1"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWait2"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWait3"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWait4"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWait5"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWait6"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWait7"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWait8"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWait9"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWaitA"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWaitB"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWaitC"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWaitD"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWaitE"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612PCMWriteWaitF"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612SeekPCM"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612WritePort0"/>
<Class name="com.io7m.jvgm.core.VGMCommandYM2612WritePort1"/>
<Class name="com.io7m.jvgm.core.VGMHeader"/>
<Class name="com.io7m.jvgm.core.VGMVersion"/>
<Class name="com.io7m.jvgm.interpreter.ym2612.VGMYM2612Callbacks"/>
<Class name="com.io7m.jvgm.interpreter.ym2612.VGMYM2612ChannelSnapshot"/>
<Class name="com.io7m.jvgm.interpreter.ym2612.VGMYM2612OperatorSnapshot"/>
<Class name="com.io7m.jvgm.parser.api.VGMParseError"/>
</Or>
</Match>
<!-- More switch-based interpreting -->
<Match>
<Package name="com.io7m.jvgm.cmdline"/>
<Bug pattern="CC_CYCLOMATIC_COMPLEXITY"/>
</Match>
<!-- Do not care about any of these issues -->
<Match>
<Package name="com.io7m.jvgm.cmdline"/>
<Or>
<Bug pattern="LO_SUSPECT_LOG_CLASS"/>
<Bug pattern="LO_TOSTRING_PARAMETER"/>
<Bug pattern="UVA_USE_VAR_ARGS"/>
</Or>
</Match>
<!-- False positive -->
<Match>
<Bug pattern="EXS_EXCEPTION_SOFTENING_NO_CHECKED"/>
<Class name="com.io7m.jvgm.parser.vanilla.VGMParserVanillaBody"/>
<Method name="parse"/>
</Match>
<!-- Not a problem -->
<Match>
<Bug pattern="SR_NOT_CHECKED"/>
<Class name="com.io7m.jvgm.parser.vanilla.VGMParserVanillaBody"/>
<Method name="parse"/>
</Match>
<!-- Not a problem -->
<Match>
<Bug pattern="SR_NOT_CHECKED"/>
<Class name="com.io7m.jvgm.parser.vanilla.VGMParserVanillaHeader"/>
<Method name="parseHeaderVersioned"/>
</Match>
<!-- Unavoidable weak messages -->
<Match>
<Bug pattern="WEM_WEAK_EXCEPTION_MESSAGING"/>
<Package name="com.io7m.jvgm.parser.vanilla"/>
</Match>
<!-- Unread fields? -->
<Match>
<Package name="com.io7m.jvgm.interpreter.ym2612"/>
<Or>
<Bug pattern="FCBL_FIELD_COULD_BE_LOCAL"/>
<Bug pattern="URF_UNREAD_FIELD"/>
</Or>
</Match>
<!-- Cannot do anything to simplify a switch-based interpreter -->
<Match>
<Class name="com.io7m.jvgm.interpreter.ym2612.VGMYM2612Interpreter"/>
<Bug pattern="CC_CYCLOMATIC_COMPLEXITY"/>
</Match>
<!-- Cannot do anything to simplify a switch-based interpreter -->
<Match>
<Package name="com.io7m.jvgm.parser.vanilla"/>
<Bug pattern="CC_CYCLOMATIC_COMPLEXITY"/>
</Match>
<!-- Noone cares about circular dependencies -->
<Match>
<Package name="com.io7m.jvgm.interpreter.ym2612"/>
<Bug pattern="FCCD_FIND_CLASS_CIRCULAR_DEPENDENCY"/>
</Match>
<!-- Seems wrong. -->
<Match>
<Class name="com.io7m.jvgm.parser.vanilla.VGMParserVanillaHeader"/>
<Method name="parseHeaderMagicNumber"/>
<Bug pattern="BL_BURYING_LOGIC"/>
</Match>
<Match>
<Or>
<Bug pattern="IMC_IMMATURE_CLASS_NO_TOSTRING"/>
<Bug pattern="OPM_OVERLY_PERMISSIVE_METHOD"/>
<Bug pattern="CRLF_INJECTION_LOGS"/>
<Bug pattern="CE_CLASS_ENVY"/>
<Bug pattern="OCP_OVERLY_CONCRETE_PARAMETER"/>
<Bug pattern="FCBL_FIELD_COULD_BE_LOCAL"/>
<Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
<Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
</Or>
</Match>
</FindBugsFilter>