Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key/certificate loading can yield inconsistent algorithm values #2

Closed
io7m opened this issue Dec 17, 2023 · 0 comments
Closed

Key/certificate loading can yield inconsistent algorithm values #2

io7m opened this issue Dec 17, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@io7m
Copy link
Member

io7m commented Dec 17, 2023

Currently, canonmill uses BouncyCastle to load private keys, but it doesn't specify a provider for parsing certificates. This can yield keys that end up being "inconsistent" with their certificates because the two end up with different algorithm names. This can end up smashing into:

https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/ssl/X509Authentication.java#L256

@io7m io7m added the bug Something isn't working label Dec 17, 2023
@io7m io7m self-assigned this Dec 17, 2023
@io7m io7m closed this as completed in aa5ce2b Dec 17, 2023
io7m added a commit that referenced this issue Dec 17, 2023
Release: com.io7m.canonmill 2.0.0
Change: Fix an issue that can cause incompatible algorithm names. (Ticket: #2)
Change: (Backwards incompatible) Require JDK 21
io7m added a commit that referenced this issue Dec 17, 2023
Release: com.io7m.canonmill 2.0.0

Change: Fix an issue that can cause incompatible algorithm names. (Ticket: #2)
Change: (Backwards incompatible) Require JDK 21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant