Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]: Preview [ Cover ] for Models an Loras #6355

Open
1 task done
ThesiiNCey opened this issue May 12, 2024 · 5 comments
Open
1 task done

[enhancement]: Preview [ Cover ] for Models an Loras #6355

ThesiiNCey opened this issue May 12, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for new contributors web ui

Comments

@ThesiiNCey
Copy link

ThesiiNCey commented May 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Contact Details

brian.rodenburg@siincey.eu

What should this feature add?

In the Models menu there is a kind of preview for the model and the Lora that you have a picture of, for example in the Gradio variant for each Model and Lora a Preview [ Cover ]

So that the drop-down menu for Loras and models is larger and there is a cover behind the Lora/Model name that is not too big but not too small either

or a popup modal window

Alternatives

No response

Additional Content

No response

@ThesiiNCey ThesiiNCey added the enhancement New feature or request label May 12, 2024
@ThesiiNCey ThesiiNCey changed the title [enhancement]: Preview for Models an Loras [enhancement]: Preview [ Cover ] for Models an Loras May 12, 2024
@psychedelicious
Copy link
Collaborator

We've got the backend for this - you can assign cover images to each model. But we don't yet have the frontend components to display the images in the model selection and LoRA card component.


If anybody wants to have a go at adding the image to the LoRA card component, I'd be happy to review a PR. It should be pretty straightforward, you'll only need to design the component.

The LoRA component is here: https://github.com/invoke-ai/InvokeAI/blob/main/invokeai/frontend/web/src/features/lora/components/LoRACard.tsx

The config object has an optional cover_image property that will be the URL of the image (if one exists).

@psychedelicious psychedelicious added good first issue Good for new contributors web ui labels May 13, 2024
@0xPratik
Copy link

can i work on this issue ?

@ThesiiNCey
Copy link
Author

If you think you can build the front end for it, I have absolutely no knowledge of that

@0xPratik
Copy link

yes i can will work on it

@psychedelicious
Copy link
Collaborator

Hi @0xPratik, sure. I've assigned the issue to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for new contributors web ui
Projects
None yet
Development

No branches or pull requests

3 participants