Wrong numbering of payment for id >100

[raptorblue]

Setup

• Version: v5.8.35-C156
• Environment: Docker

Describe the bug

The numbering of payments >100 is wrong. The counter in "generated numbers" is 101 for payments but when creating a new payment for an invoice it has a name like 100_dm56a instead of 101. Manually changing the name to 101 works but even with setting the counter manually to 102 (or even 110) does not help for the next time and I end up with another payment 100_xfnfA.

Steps To Reproduce

Have already 100 payments for invoice and add another one.

Expected Behavior

New payment should have number 101 not 100_something

Screenshots

See attachment

Logs

No related logs.

[turbo124]

you will see this issue if you have made a change to the payment number counter.

The system will attempt to get the next payment number, however if this has already been used, it will increment to the next counter.

If after 500 attempts no unique counter is found, the number will be inserted with the _XXXXX format.

[raptorblue]

Hi,

Thanks for the quick reply. The strange thing is:

• I've never manually set the counter value before (until the _XXXXX ids started appearing)
• I have payment numbers from 001 to 100 without any issue
• When I try to set the id to something that already exists (i.e. 095) an error shows (as expected) but manually setting the payment ids to 101, 102, 103 ... works. So, there is no collision.

My guess is that somehow the lookup for a new id only runs to 100, does not fine one within the 500 tries you mentioned and then assigns 100_blabla. Does this make sense?

Thx & BR
Raptor

[raptorblue]

I've just tried another thing:

• Set the number format (which was blank before) for Payment to X{$counter} and the counter to 1000
• Created a new payment and ended up with payment number X001 and counter 2
• Set the counter to 5
• Next number was X002 and counter was 3
• Set the counter to 123
• Next number was X003 and counter was 4