v2 Payment link generate bad invoice numbers

[Quack6765]

Setup

• Version: v5.8.8-C148
• Environment: Docker

Checklist

• Can you replicate the issue on our v5 demo site https://demo.invoiceninja.com or https://react.invoicing.co/demo? No since I can't use the registration required option for the payment link
• Have you searched existing issues? Yes
• Have you reported this to Slack/forum before posting? No
• Have you inspected the logs in storage/logs/laravel.log for any errors? Yes. Nothing

Describe the bug

Steps To Reproduce

Create a new payment link. Using the /v2 link, choose a payment type. After the loading and once the form for the payment info appears, go back to the customer portal main page without paying the invoice. After that check the admin panel to see the wrong invoice number. Also the status of the invoice is Sent but there is actually no email being sent at all. The invoice also doesn't appear in the Customer Portal but I'm assuming this is caused by the wrong invoice number.

Expected Behavior

Generate a good invoice number, send the email to the customer about the new invoice and show it in the customer portal.

Screenshots

Logs

None

[turbo124]

@Quack6765 these "invoices" are only proforma, and there is a cleanup cron job that runs for these which removes them from the UI.

[Quack6765]

So if I understand correctly the number will never "convert" to the same format as the other ones even once paid ? The email sent to the customer is using this weird number so it make it seems like some sort of bug. Plus the initial email when the invoice is initially generated is never sent but the subsequent ones are.

Plus even after payment, the subscription,invoices,recurring invoices pages of the customer portal are all still empty just like if it can't find the invoice in question. Since it was paid using a payment link it's my understanding that it should at the bare minimum show up in the subscription page.