Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Spell check on editable fields? #564

Open
LiamKarlMitchell opened this issue Apr 13, 2023 · 5 comments
Open

[Feature Request] Spell check on editable fields? #564

LiamKarlMitchell opened this issue Apr 13, 2023 · 5 comments

Comments

@LiamKarlMitchell
Copy link

LiamKarlMitchell commented Apr 13, 2023

What version of Invoice Ninja are you running? ie v4.5 / v5
v5.5.103-SC113 Self Hosted - using Web Browser App

What environment are you running?
Docker

Have you searched existing issues/requests?
Yes
See also: https://forum.invoiceninja.com/t/no-spell-check-might-be-the-end-of-us/10122

Screenshots
image

As a company user when a typo is made in a text input area then I would expect the Spell Check feature to work.
If in web browser it should use the built in spell checker if possible. Such as in Google Chrome.

Is this maybe already implemented and just something I have to turn on?
I tried to find in docs but no info was easily apparent to me if so.

Cheers

@hillelcoren hillelcoren transferred this issue from invoiceninja/invoiceninja Apr 13, 2023
@hillelcoren
Copy link
Member

Hi,

We're blocked on this by the framework we're using, if you change to the React app it should work correctly.

@LiamKarlMitchell
Copy link
Author

LiamKarlMitchell commented Apr 13, 2023

Thanks @hillelcoren , I'll have to take a look at the react app is this it?
https://github.com/invoiceninja/ui
Says it is early preview.


For Flutter I see this issue, and I'm sure the team is already aware but just in-case someone else is searching for more info.
flutter/flutter#40682

From what I've read, it is possible in browser to enable the spell check attribute on the dom element for text inputs.
Just tried it out in JS console when focusing an input on quote line and it works, but not without issues such as scrolling text areas are not displaying the location of red squigglys correctly how unfortunate.

image
image

document.activeElement.setAttribute('spellcheck','true');

@hillelcoren
Copy link
Member

That's the code, you can switch to the React app using the icon button on the dashboard.

Spell check is being worked on but isn't quite ready for production, hopefully soon.

@LiamKarlMitchell
Copy link
Author

LiamKarlMitchell commented Apr 13, 2023

Confirming it works on React UI repo.
image

Love the larger text inputs :)
Edit: Found the button in dashboard thanks!

@hillelcoren
Copy link
Member

This issue is being tracked in the framework we're using here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants