-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: steps
seem to run independent from each other
#705
Comments
What do you think @jessicatarra, would it make sense running all the steps in the same context? |
I would understand if you keep it like this (also because it's more consistent with GitHub workflows), but then I feel like we would need to be clear about that in the docs and reopen #470? |
I don't think 470 is exactly about this use-case so it's better to use a new issue for that. |
While it's not specifically about this, it was closed with the reason that run: |
command1
command2 (which didn't work on windows) is equivalent to the new steps:
- command1
- command2 But it isn't, as long the steps are executed in different contexts. So I think the issue should remain open, since there is still no way to get a multi command script to work on windows without resorting to |
I think that is how it is intended to be (it's kind of just abusing a yaml feature to support multiple lines), Melos doesn't transform the result into a shell script with multiple lines. |
This issue will be solved by #711 |
Is there an existing issue for this?
Version
5.3.0
Description
When defining a script with multiple steps, the working directory from the previous step doesn't seem to be maintained for the next step. This means
steps
is not a working fix for #470 as far as I understand.Steps to reproduce
melos run fail
Expected behavior
The script should print
{workspace_root}/packages
, but the second step happens in the workspace root again.Screenshots
No response
Additional context and comments
No response
The text was updated successfully, but these errors were encountered: