-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request: auto sign-off when commit use melos version
#591
Comments
melos version
I'm not sure if Melos should directly support this itself, however we can enable you to do this perhaps by adding another hook to the version command (https://melos.invertase.dev/commands/version#hooks) that allows you to do your own command for committing already staged files (like preCommit allows you to stage your own extra things) Wdyt? And are you willing to do a PR for it? 😄 |
I can't understand the precommit part of the document and what step this preCommit does. I can only view it through the source code. If I were to open PR to handle the problem, I should do one of the following two things:
Of course, they all also support configuring corresponding parameters in melos.yaml |
I would also like to see this supported. |
Isn't it enough if you just set |
Nope commit signing and the Signed-off-by tag are different things. |
Ah right, of course. I guess the only way to do it outside of melos is something like this then:
|
Is there an existing feature request for this?
Command
No response
Description
Add sign-off and GPG sign for commits.
Reasoning
Signing a commit in git is a necessary thing to ensure that the commit was initiated by a validator.
Additional context and comments
In commits, the command I often use is
git commit --signoff -S
I wish there was an option added to
melos version
The text was updated successfully, but these errors were encountered: