-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If a root project has plugins enabled, projects in sub-folders should have those plugins too #188
Comments
Hey @rrousselGit, I'm wondering if it's possible to run
It goes without saying that having the IDE highlighting problems is really handy but taking into account that the IDE may become very slow on larger mono-projects (we have 100+ dart/flutter packages already, and it is not recommended for 10+ packages) it can be handy to run the checks just in terminal/CI. |
Yes that works. |
@rrousselGit, then I must be missing something. I get the lints when I run But when I run the same command without So, what will be the correct way to run the checks in the terminal without having to enable the plugin for the IDE? |
Actually you're correct, I've changed that at some point. |
@rrousselGit, I'm a bit confused. So running the checks from a terminal without enabling |
Kind of. The command line voluntarily excludes projects where it isn't enabled, to avoid cases where the linter runs in places where it shouldn't |
Would it make sense then to do the filtering based on the presence of |
You can technically install the command line globally and not add it as dev_dependency |
So, do you see the value in having an option to run the tool without the need to enable the analyzer_plugin? If so, do you see a relatively easy way to get it implemented? |
Supporting that isn't hard. It's just about removing one Overall I'm skeptical about the value. If you have concerns about the IDE performance, I'd rather look into that first. |
Our team would also find it valuable to be able to run custom_lint from the command line while disabling the plugin in analysis_options.yaml. Unfortunately, we've had multiple devs negatively impacted by the increased memory and CPU usage after I added custom_lint to our (rather large monorepo) project. However, we would still gain good value by being able to run our custom lint rules via custom_lint in CI (or locally via command line). Alternatively, (and maybe this isn't a great idea), it could be useful to support an env var or maybe a dart/flutter vs code extension config that allows individual developers to opt out of custom analyzer plugins. |
Currently in a mono-repo, all projects need to install custom_lint + plugins.
We could alleviate that by having a pubspec at the root of the workspace which installs both custom_lint and plugins. And then enable plugins for all sub-projects in the workspace.
The text was updated successfully, but these errors were encountered: