Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline config.json #30

Open
inverse opened this issue Jun 20, 2021 · 1 comment · Fixed by #42
Open

Streamline config.json #30

inverse opened this issue Jun 20, 2021 · 1 comment · Fixed by #42
Labels
enhancement New feature or request

Comments

@inverse
Copy link
Owner

inverse commented Jun 20, 2021

Right now the way things are setup with config.json makes it hard to support both local and pre-built.

We should adopt what other extensions do like groccy.

Which as I understand is within config.json

  • set version to dev for local builds
  • Drop the image key to allow local builds

Figure out how those get patched on cI for releasing or if it's controlled via build-args
@inverse inverse added the enhancement New feature or request label Jun 20, 2021
@inverse inverse mentioned this issue Jul 19, 2021
Merged
@inverse inverse reopened this Aug 22, 2021
@inverse
Copy link
Owner Author

inverse commented Aug 22, 2021

Previous attempt exposed dev to end users as an upgrade path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve development flow inverse/hassio-addon-emoncms
1 participant
@inverse