Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Handlebars email templates with Svelte alternative #738

Open
maxlath opened this issue Mar 22, 2024 · 0 comments
Open

replace Handlebars email templates with Svelte alternative #738

maxlath opened this issue Mar 22, 2024 · 0 comments

Comments

@maxlath
Copy link
Member

maxlath commented Mar 22, 2024

I'm currently debugging an issue where a handlebars template calls the imgSrc function without the last optional argument, but passes instead its handlebars template context object. That should be a type error, but as Handlebars template don't have type checking, the wrong types can not be detected. As the client is now almost fully Sveltified, it seems to be right thing to do to try to get the server to use that same view rendering language here on the server.

Options:

maxlath added a commit that referenced this issue Mar 27, 2024
…ects

which was the cause for imgSrc to return https://inventaire.io/img/users/64x[object Object]/ff6801a9f12779e9fb1561ff3f5a7cd1576f79

Maybe it's time to replace Handlebars #738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant