Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple series with multiple ordinals #732

Open
nclm opened this issue Feb 16, 2024 · 2 comments
Open

Support for multiple series with multiple ordinals #732

nclm opened this issue Feb 16, 2024 · 2 comments
Labels

Comments

@nclm
Copy link
Contributor

nclm commented Feb 16, 2024

Already mentioned in #472 #433 and inventaire/inventaire-client#413 but I couldn’t find a specific ticket about it.

When a work is part of several series, each with an ordinal:

  • The work isn’t ordered on the series pages
  • The ordinals don’t appear anywhere

A minimum goal could be to have those appearing properly. A more advanced version would allow editing multiple series each with their ordinal.

@nclm
Copy link
Contributor Author

nclm commented Feb 16, 2024

Mock-up of how editing could work:

This is trying to do with minimum changes:
– “Series ordinal” block moved up to just under “Series” block
– Series ordinal now has one field per series
– Otherwise everything stay the same

The real ideal way to implement this might be by editing the ordinal within the series block, like on Wikidata. But that means supporting subfields for qualifiers, which is a bigger UI change. I think the minimum change would already work well.

@maxlath
Copy link
Member

maxlath commented Feb 19, 2024

I think the "proper" way to support multiple series would be to get closer to the Wikidata way, where series ordinals are represented as qualifiers, thus directly nested within the serie claim:
Capture d’écran du 2024-02-19 14-24-40

This is not an option with our current simplified claim data model, but we will need to complexify it anyway to support references, see #710, so also adding support for qualifiers seems doable (and would allow to scrap the data model adapter added by #565). Issue on adding qualifier support #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants