Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make verifyClaimConcurrency also check Wikidata for non-ISBN external ids #725

Open
maxlath opened this issue Feb 2, 2024 · 0 comments
Open

Comments

@maxlath
Copy link
Member

maxlath commented Feb 2, 2024

verifyClaimConcurrency currently only checks the local entities database, as it was initially designed for ISBNs (properties for which we currently ignore Wikidata, cf #182).

I had the case that I re-added a Theses.fr person (wdt:P4285) ID (087735768) to a local entity, while there was already a duplicate author with that ID on Wikidata (wd:Q45463524). In that case, we could either

  • refuse adding the ID to the local entity (as is the case today when trying to use an ISBN already used), and open a deduplicate task (but with the issue that this could happen for entities of any type, which do not support at the moment)
  • refuse it but offer to merge with the concurrent entity, once all users can attempt to merge entities allow non-dataadmins users to merge entities #491
  • accept it and trigger a /api/tasks?action=check-entities on the local entity, as that should then trigger an automerge, based on the external ids checks (again with the limitation that this could happen for entities of any type, which tasks do not support at the moment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant