Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment on an element #717

Open
jum-s opened this issue Jan 26, 2024 · 3 comments
Open

Add a comment on an element #717

jum-s opened this issue Jan 26, 2024 · 3 comments

Comments

@jum-s
Copy link
Contributor

jum-s commented Jan 26, 2024

This comment would have its own table server side (document would be with an elementId key).

@maxlath
Copy link
Member

maxlath commented Jan 26, 2024

Why not just a text field like details or notes on items? Is there any metadata specific to the comment that wouldn't make sense to have on the element document?

@jum-s
Copy link
Contributor Author

jum-s commented Feb 9, 2024

To be more granular about multiple comments of the same element (?)

2 examples:

  • having a comment's timestamp would allow to have comment's replies or to sort by newest comment, this comment time could be derived from the element timestamp but one may add comment at a different time than creating an element.
  • some form of upvote could be attached to each comment
    many other things could that will arise when comments in use (a tagging system?).

That said, im not against KIS text field either, i just imagined it with a table, but maybe it too much.

@jum-s
Copy link
Contributor Author

jum-s commented Apr 24, 2024

Lets start by a textfield for the moment, the element being the timestamp and entity URI link to find the comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants