Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with clear facets button #266

Open
Ducica opened this issue Mar 7, 2024 · 2 comments
Open

Issue with clear facets button #266

Ducica opened this issue Mar 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Ducica
Copy link
Contributor

Ducica commented Mar 7, 2024

Package version (if known): latest 2.2.5

Clear button in Bucket aggregations is not working.

image

You can see also in Zenodoo, when one clicks on clear it duplicates this aggregation, instead of eliminating it.

image

As I see it, the issue is in the implementation of updateQueryFilters selector

@Ducica Ducica added the bug Something isn't working label Mar 7, 2024
@ulysseus-eu
Copy link

I think it is linked to this commit: 908fd5c

Let me know what you think but reverting the commit seems safer than taking more time to find a fix to the corner case.
It's affecting all instances with recent JS dependencies, whatever the invenio-rdm version.

@zzacharo
Copy link
Member

ping @psaiz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants