Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doi: doi component doesn't display errors on first save #403

Open
zzacharo opened this issue Dec 8, 2021 · 1 comment
Open

doi: doi component doesn't display errors on first save #403

zzacharo opened this issue Dec 8, 2021 · 1 comment
Labels
bug Something isn't working ux

Comments

@zzacharo
Copy link
Member

zzacharo commented Dec 8, 2021

Package version: RDM@v7.0

Describe the bug

The PIDField component doesn't display errors when you click save for the first time

Steps to Reproduce

  1. Go to '/uploads/new'
  2. Fill in a random value as an external DOI e.g 1234
  3. Click on Save draft
  4. See the errors in the top section and specifically the DOI: invalid scheme
  5. Notice that the PIDField is not in an error state.
  6. Change the field in another invalid value and click save again.
  7. See that now the PIDField is correctly in an error state.

Expected behavior

The component should be in an error state after the first save.

Additional context

Maybe it's worth cheking formik.setStatus() function in which you can set an arbitrary state e.g backendErrors. That way, we can distinguish backend from frontend errors. To evaluate the extend of changes needed.

@zzacharo zzacharo added the bug Something isn't working label Dec 8, 2021
@lnielsen
Copy link
Member

lnielsen commented Dec 8, 2021

Left over from #401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ux
Projects
InvenioRDM QA
High priority
Development

No branches or pull requests

2 participants