Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign up and password reset #315

Open
janequist opened this issue Dec 28, 2020 · 3 comments
Open

Sign up and password reset #315

janequist opened this issue Dec 28, 2020 · 3 comments

Comments

@janequist
Copy link

janequist commented Dec 28, 2020

Happy holidays and a wonderful new year to all of you! I had briefly looked into this project last month and will resume/continue the evaluation again this week.

First item on the list:
Need sign up and password reset.

On behalf of an institutional client, am considering hosting/deploying this software for a limited Beta trial open to a bunch of users to get their feedback in early Jan. The current pre-created user ids and passwords are not appropriate and will not work as there may be conflicts if more than one person uses the same id. The users should sign up by themselves to prevent errors.

HIGH PRIORITY.
Thanks!
MaryJane

@janequist
Copy link
Author

Coupla comments on above:

  1. Seems like Github/OAuth is supported but not enabled.
    For social logins - Google and Twitter or FB might be more useful/relevant to the user base here.

  2. The system may need to capture additional info than mere email via social login. For one thing, the user needs to optionally register with address in order to select the "Delivery" option for a loan.

  3. ActiveDirectory/LDAP import will be quite useful.

  4. SSO support (with SAML - Okta, etc.) may come up later with our client IT department - I'll find out specifics later. Of course, mainly backend and API support may be required so that we don't fork changes that are incompatible with future upgrades to the master branch.

@ntarocco
Copy link
Contributor

ntarocco commented Jan 5, 2021

This is already tracked here:

It would probably better if we have a chat to understand your needs and what it blocking you. You can join our Discord chat (see Chat section here).
We are building InvenioILS trying to keep it generic so that other organization can use it, as you are probably doing. At the same time, we are giving priority to our needs as first to fulfill our requirements and make our customers happy.
Since it is an open source project, we are always happy when we receive external contributions and this could be a way to implement more quickly what is missing.

@janequist
Copy link
Author

One would think that the signup and password reset is an essential function required of any application for even test deployment and users to use it. I dont understand why it is tracked in #47/48 as "nice to have" - maybe I am missing something.

In any case, I just poked around a bit and it seems the exposed API for patrons is missing the CRUD operations, except list/get and so that is a minor roadblock. But just now reviewed the db and the necessary tables for patrons like accounts_user have been created in the schema. So, it should be quite a minor enhancement to expose it in the API [and the forms should be trivial or we can do it ourselves]. As indicated in the previous comment, I am not sure if it is a good idea for us to fork and maintain the project for such a small change at this point.

Re: other enhancements like LDAP and SSO/SAML, I can agree it is non-trivial and we'd be happy to do it + contribute these enhancements back, when we fully go ahead with the project after the evaluation.

Have more questions regarding the backend since some design choices seem to be non traditional and would like to understand your architecture and decisions better. Any backend documentation you can publish will help.

Re: chat - we are in California/SiliconValley and need to sync up times - something we can do down the road.

Thanks,
MJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants