Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files: clarify transfer object/factory responsabilities and calling order #420

Open
ppanero opened this issue Nov 1, 2022 · 1 comment

Comments

@ppanero
Copy link
Member

ppanero commented Nov 1, 2022

The Transfer object is called from within the service components:

FileService -> {Metadata/Content}Component -> Transfer.

However, the Transfer objects sometimes need the service (id) and uow, for example, to register the file fetching task (FetchTransfer).

The calling flow (see above) is not very transparent, since we are calling a class while just doing parameter forwarding. Can this be split/encapsulated better?

Would it make sense to have a TransferComponent? This would already have a service and uow and could perform some checks and only register the tasks then. On the other hand, it would expose the TransferType (or how to check if not local?)

@max-moser
Copy link
Contributor

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants