You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In CustomFieldsService.exists we need an is_registered method/flag for the fields. To check if it is "configured" or not, not just to check existance in ES, or should it do both?
This issue boils down to a persistence problem. We need to store which fields have passed by the invenio-cli custom-fields create... command. We cannot do it in memory, because they would be lost for the following app instantiation (e.g. pod rollup). Options are:
DB table. This would allow us to add another command "disable", that would invalidate the field for future records while keeping it in the ones that it's present (potential issues with marshmallow when dumping)
Registry. On application start, ES would be checked for fields existence (comparing to the configured custom fields). The mapping type should also be checked, otherwise, it could give a false positive (i.e. a field was auto guessed, the app was restarted and now it seems as if it was enabled).
In
CustomFieldsService.exists
we need anis_registered
method/flag for the fields. To check if it is "configured" or not, not just to check existance in ES, or should it do both?related to #355
The text was updated successfully, but these errors were encountered: