Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parent PID configuration for non-DataCite setup #1652

Open
tmorrell opened this issue Jan 31, 2024 · 4 comments · May be fixed by #1740
Open

Parent PID configuration for non-DataCite setup #1652

tmorrell opened this issue Jan 31, 2024 · 4 comments · May be fixed by #1740
Assignees
@lnielsen
Labels
bug Something isn't working

Comments

@tmorrell
Copy link
Contributor

Package version (if known): v12d

Describe the bug

The current configuration of parent PIDS assumes that DataCite is enabled

invenio-rdm-records/invenio_rdm_records/config.py

Line 377 in a9eab71

RDM_PARENT_PERSISTENT_IDENTIFIERS = {
, but the default is that DataCite is not enabled

invenio-rdm-records/invenio_rdm_records/config.py

Line 394 in a9eab71

DATACITE_ENABLED = False
. This will result in issues for a standard install.

  • Should DataCite be a requirement?
  • Do we need a config to turn off parent pids? (This would be useful for us)
  • Can a different pid be used as the default?
@tmorrell tmorrell added the bug Something isn't working label Jan 31, 2024
@utnapischtim
Copy link
Contributor

Note: the parent_doi is used in invenio_rdm_records/service/config.py i think this should be a ConditionalLink as in here

@tmorrell tmorrell changed the title Parent PID configuration for non-DataCite configuration Parent PID configuration for non-DataCite setup Jan 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

This issue was automatically marked as stale.

@github-actions github-actions bot added the stale label Apr 1, 2024
@utnapischtim
Copy link
Contributor

related to discussion around DOI's of restricted records: inveniosoftware/product-rdm#178

@utnapischtim utnapischtim removed the stale label Apr 2, 2024
@lnielsen lnielsen self-assigned this Apr 2, 2024
@utnapischtim
Copy link
Contributor

related to inveniosoftware/product-rdm#194

@utnapischtim utnapischtim linked a pull request May 2, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lnielsen lnielsen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

parent-doi: add configuration utnapischtim/invenio-rdm-records
3 participants
@utnapischtim @lnielsen @tmorrell