parent-doi: add configuration #1740
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slint
approved these changes
May 3, 2024
There was a problem hiding this comment.
I like the solution, and decoupling DataCite semantic/config from PID configuration :)
I have to admit I'm a bit confused by the "protocol" naming, since it reminds me of HTTP/transfer protocol. Since we've already did the bad thing and hardcoded special rules for the DOI in these classes, maybe it makes sense to just double-down and name the param/field doi_enabled_cfg_key.
I would later on deprecate this class and refactor to fully disassociate DATACITE_ENABLED from it, make the "doi" magic-string configurable, etc. and then either:
- make a major version bump, and break the API
- keep the old class for backwards compact and make a new one
utnapischtim
force-pushed
the
fix-concept-doi-requirement
branch
from
5705374
to
7349ec6
Compare
* with this it is possible to create doi's for parent and record independently. * this removes the semantically overload of DATACITE_ENABLED * it adds also the possibility to change from DATACITE to another doi provider
utnapischtim
force-pushed
the
fix-concept-doi-requirement
branch
from
7349ec6
to
93e62ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #1652
QUESTIONS:
the problem with that is, that it is not backwards compatible to the actual code, BUT it would be backwards compatible to v11
PARENT_DOI_ENABLEconfig will be merged this should be added to the migration script too