Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affiliations ROR: enrich existing data + fix UI inconsistencies #1589

Open
alejandromumo opened this issue Oct 30, 2023 · 4 comments
Open

Affiliations ROR: enrich existing data + fix UI inconsistencies #1589

alejandromumo opened this issue Oct 30, 2023 · 4 comments
Labels
bug Something isn't working stale

Comments

@alejandromumo
Copy link
Member

UI inconsistencies

  • We have two types of serialization. One for person and one for organizations. They should be consistent.
  • Both dropdown options should display the same information (e.g. one has icons, the other doesn't, one has acronyms inside parenthesis while the other does it underneath the name).
  • There is no way to differentiate two affiliations with the same name (like Heidelberg University and Heidelberg University), the only differentiation is the ROR id which is not that useful for the end user (more on this on the data model concerns)
  • The affiliations accordion in the record's landing page does not show both affiliations if they have the same. It's a bit of an edge case. Anyway, this happens because the UI serializer (backend) aggregates the affiliations by name instead of id.

Concerning the data dump

  • We need to enrich the information we have on affiliations so we can clearly differentiate two affiliations. Each name + location seems like a good candidate.

See: https://ror.readme.io/docs/create-ror-powered-typeaheads

@alejandromumo alejandromumo added the bug Something isn't working label Oct 30, 2023
@tmorrell
Copy link
Contributor

I'm going to be doing some of the same ROR enhancements for the funders field, which has a lot of the same issues. I think our ROR handling can be harmonized-let me know if you're going to start working on this so we can coordinate.

Copy link
Contributor

This issue was automatically marked as stale.

@github-actions github-actions bot added the stale label Dec 30, 2023
@tmorrell tmorrell removed the stale label Dec 31, 2023
Copy link
Contributor

This issue was automatically marked as stale.

@github-actions github-actions bot added the stale label Feb 29, 2024
@tmorrell tmorrell removed the stale label Feb 29, 2024
Copy link
Contributor

This issue was automatically marked as stale.

@github-actions github-actions bot added the stale label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants