Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

access-requests: refactor the way permissions for (user/guest) access request creation is handled #1364

Open
zzacharo opened this issue Jul 17, 2023 · 1 comment
Open

access-requests: refactor the way permissions for (user/guest) access request creation is handled #1364

zzacharo opened this issue Jul 17, 2023 · 1 comment
Labels
stale

Comments

@zzacharo
Copy link
Member

Right now, the permission checks in the access service for creating work but they are implemented pretty heavy-handedly.
We should rework the checks in a way that they utilize generators and the permission policy like the all other service methods.

  • invenio_rdm_records.services.access.service:RecordAccessService.create_user_access_request()
  • invenio_rdm_records.services.access.service:RecordAccessService.create_guest_access_request()
  • invenio_rdm_records.services.access.service:RecordAccessService.create_user_access_request()
@github-actions
Copy link
Contributor

This issue was automatically marked as stale.

@github-actions github-actions bot added the stale label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zzacharo