Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make consistent module placing #922

Open
ppanero opened this issue Mar 16, 2023 · 0 comments
Open

make consistent module placing #922

ppanero opened this issue Mar 16, 2023 · 0 comments

Comments

@ppanero
Copy link
Member

ppanero commented Mar 16, 2023

invenio-records-resources defines a file/module hierarchy base on layers (records, services, resources). Then inside each one of them are the specifics for each record type (e.g. communities, members, etc.). This module has a mix between an inverse approach defining root modules for record types (communities, members) and then inside each of them the layers. Additionally, there is a records module in the root which is confusing, a schema.py (services) and resolvers (should be records data access layer) file in the root of communities which should be in the services layer, permissions.py in the root instead of in the /services...

TL;DR: needs mass file placement refactoring

/resources
|
|- /communities
|- /members 

/services
|
|- /communities
|- /members 

/records
|
|- /communities
|- /members 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant