Admin Page: Action Error Featuring Private Community

[fenekku]

from colleague

Provide a more descriptive error when trying to feature a private community. I thought I was entering the start date wrong, until I checked the request logs.

In the logs

127.0.0.1 - - [10/Mar/2023 16:10:42] "POST /api/communities/ad4bc1f7-0f57-47ff-a0e6-e7d94d5f9cf3/featured HTTP/1.1" 400 -
[2023-03-10 16:10:44,241] DEBUG in errors: A resource error handler caught the following exception:
Traceback (most recent call last):
  File "/Users/me/.local/share/virtualenvs/digitalhub-2-jXqWR1nq/lib/python3.9/site-packages/flask/app.py", line 1823, in full_dispatch_request
    rv = self.dispatch_request()
  File "/Users/me/.local/share/virtualenvs/digitalhub-2-jXqWR1nq/lib/python3.9/site-packages/flask/app.py", line 1799, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
  File "/Users/me/.local/share/virtualenvs/digitalhub-2-jXqWR1nq/lib/python3.9/site-packages/flask_resources/resources.py", line 65, in view
    return view_meth()
  File "/Users/me/.local/share/virtualenvs/digitalhub-2-jXqWR1nq/lib/python3.9/site-packages/flask_resources/content_negotiation.py", line 116, in inner_content_negotiation
    return f(*args, **kwargs)
  File "/Users/me/.local/share/virtualenvs/digitalhub-2-jXqWR1nq/lib/python3.9/site-packages/flask_resources/parsers/decorators.py", line 51, in inner
    return f(self, *args, **kwargs)
  File "/Users/me/.local/share/virtualenvs/digitalhub-2-jXqWR1nq/lib/python3.9/site-packages/flask_resources/parsers/decorators.py", line 51, in inner
    return f(self, *args, **kwargs)
  File "/Users/me/.local/share/virtualenvs/digitalhub-2-jXqWR1nq/lib/python3.9/site-packages/flask_resources/parsers/decorators.py", line 90, in inner
    return f(self, *args, **kwargs)
  File "/Users/me/.local/share/virtualenvs/digitalhub-2-jXqWR1nq/lib/python3.9/site-packages/flask_resources/responses.py", line 39, in inner
    res = f(*args, **kwargs)
  File "/Users/me/.local/share/virtualenvs/digitalhub-2-jXqWR1nq/lib/python3.9/site-packages/invenio_communities/communities/resources/resource.py", line 181, in featured_create
    item = self.service.featured_create(
  File "/Users/me/.local/share/virtualenvs/digitalhub-2-jXqWR1nq/lib/python3.9/site-packages/invenio_records_resources/services/uow.py", line 324, in inner
    res = f(self, *args, **kwargs)
  File "/Users/me/.local/share/virtualenvs/digitalhub-2-jXqWR1nq/lib/python3.9/site-packages/invenio_communities/communities/services/service.py", line 351, in featured_create
    self.run_components(
  File "/Users/me/.local/share/virtualenvs/digitalhub-2-jXqWR1nq/lib/python3.9/site-packages/invenio_records_resources/services/base/service.py", line 72, in run_components
    getattr(component, action)(*args, **kwargs)
  File "/Users/me/.local/share/virtualenvs/digitalhub-2-jXqWR1nq/lib/python3.9/site-packages/invenio_communities/communities/services/components.py", line 115, in featured_create
    raise ValidationError(
marshmallow.exceptions.ValidationError: The community is not public.