Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override: improve overridable components #2041

Labels
stale No activity for more than 60 days.

Comments

@jrcastro2
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Some components are reused by different react apps but they are not properly namespaced. This casues that the components cannot be overriden in each react app.

Describe the solution you'd like

Each react app should be able to override it's own components without affeting components from other react apps.

Describe alternatives you've considered

When setting the ids of the overridable components, they have the be build with the id of the app.

Additional context

Thie implementation of this was started and partially implemented by the following issue #2018

Repositories that should include the namespacing:

  • invenio-requests
  • react-invenio-deposit
  • invenio-administration

It would aslo be nice to review how the Overridable cmp is being used internally between the modules and if we can improve how we share the appName among the components (appName is used to buid the overriden ID).

@github-actions
Copy link
Contributor

This issue was automatically marked as stale.

@github-actions github-actions bot added the stale No activity for more than 60 days. label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No activity for more than 60 days.
Projects
None yet
1 participant