Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: expose metrics in result objects #2603

Open
slint opened this issue Mar 5, 2024 · 1 comment
Open

services: expose metrics in result objects #2603

slint opened this issue Mar 5, 2024 · 1 comment
Labels
stale No activity for more than 60 days.

Comments

@slint
Copy link
Member

slint commented Mar 5, 2024

We should not use the private field _results of the RecordList object. This field is encapsulated by the object and exposed through public properties such as aggregations. However, only labelled facets of the results are exposed as aggregations.

To support other aggregations, i.e. metric aggregations, we'd need to either (1) extend the RecordList class to support it or (2) modify the existing aggregations property.

For (1), it was hard for me to implement since the DSL AggResult object does not differentiate the aggregations. I believe we'd need something more custom and, IMO, it looks like a feature on its own.

For (2), it's easier to implement but modifies the existing feature.

That being said, I went with using the private field directly - which is not ideal - to unblock the development until we decide which route we want to take.

Originally posted by @alejandromumo in #2598 (comment)

Copy link
Contributor

github-actions bot commented May 5, 2024

This issue was automatically marked as stale.

@github-actions github-actions bot added the stale No activity for more than 60 days. label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No activity for more than 60 days.
Projects
None yet
Development

No branches or pull requests

1 participant